Skip to content

[v16] Fix auto-update re-exec arguments modified by aliases#51182

Merged
vapopov merged 1 commit intobranch/v16from
vapopov/fix-autoupdate-re-exec-with-aliases-v16
Jan 18, 2025
Merged

[v16] Fix auto-update re-exec arguments modified by aliases#51182
vapopov merged 1 commit intobranch/v16from
vapopov/fix-autoupdate-re-exec-with-aliases-v16

Conversation

@vapopov
Copy link
Copy Markdown
Contributor

@vapopov vapopov commented Jan 17, 2025

Backport #50228 to branch/v16

changelog: Fixed client tools auto-updates executed by aliases (causes recursive alias error)

@github-actions github-actions Bot added size/md tctl tctl - Teleport admin tool tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Jan 17, 2025
* Fix auto-update re-exec arguments modified by aliases

* Make arguments to be required to set

* Restore progress bar show before request

* Improve integration tests to execute with `tsh` and `tctl`

Added a full-cycle integration test to verify client tools
auto-updates within a test cluster by modifying AutoUpdateConfig
and AutoUpdateVersion resources. The test executes the login
command using alias configurations to ensure no recursive
re-execution occurs.

The updater binary used in integration tests has been replaced
with the `Run` logic of tctl and tsh.

* Set generated test password by env variable instead of constant value

* Restore priority of env check over remote check

In case of double re-execution case we should stop second one to prevent loop re-execution
Drop localDir set during compilation
@vapopov vapopov force-pushed the vapopov/fix-autoupdate-re-exec-with-aliases-v16 branch from 4913cb2 to 16de128 Compare January 17, 2025 17:19
@vapopov vapopov added this pull request to the merge queue Jan 18, 2025
Merged via the queue into branch/v16 with commit 2d92093 Jan 18, 2025
@vapopov vapopov deleted the vapopov/fix-autoupdate-re-exec-with-aliases-v16 branch January 18, 2025 01:27
@camscale camscale mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport size/md tctl tctl - Teleport admin tool tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants